Link to local installation instructions in CONTRIBUTING.md#2732
Link to local installation instructions in CONTRIBUTING.md#2732kurahaupo wants to merge 1 commit intomozilla:mainfrom
Conversation
|
|
||
| 1. Choose [an issue][issues] that you would like to work on. | ||
| 2. Fork the repository and follow the instructions for setting it up locally. | ||
| 2. Fork the repository and follow the [instructions for setting it up locally](https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/). |
There was a problem hiding this comment.
Would it be better to recommend that contributors run npm run dev? That uses web-ext to automatically install the add-on in a temporary instance of Firefox.
There was a problem hiding this comment.
I'm aiming to add a link under the existing text, not to rewrite the text, since that's a job for someone who understands it much better than me. But in the meantime, having some instructions is better than none.
When I try using npm I simply get:
npm: command not found
That said, I'm sure npm will be the simpler option for many, but without a gazillion gigabytes of RAM, running extra instances of Firefox is painful. I'd rather just install it in my normal instance, so that I can test it with my normal workflow using all my other plugins. (Especially it's critical to me that FoxyProxy is active.)
So how about mentioning both options? In particular, how about including that one-line option on the target page?
2 participants
Before submitting your pull request
I ran(n/a)npm testand all tests passed.I added test coverages if relevant.(n/a)Description
"follow the instructions" ... umm, what instructions?
That omission had been bugging me for a while, then today I came across this page in Mozilla Dev.
If there are some other instructions that would be more appropriate, please adjust this accordingly.
Type of change
Select all that apply.